Update projectRoot in launchPackager.bat #24115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`launchPackager.bat` starts metro server but does not pass projectRoot to it so metro server starts in the wrong directory, It is because `startServerInNewWindow` pass `react-native` directory instead of `projectRoot` in the third argument of `spawn()` in `runAndroid.js`
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Tech: Bundler 📦
facebook-github-bot
approved these changes
Mar 25, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @nazreinkaram in 9db347f. When will my fix make it into a release? | Upcoming Releases |
AnimaSA
pushed a commit
to AnimaSA/react-native
that referenced
this pull request
Mar 27, 2019
Summary: `launchPackager.bat` starts metro server but does not pass projectRoot to it. So metro server starts in the wrong directory, It is because `startServerInNewWindow` pass `react-native` directory instead of `projectRoot` in the third argument of `spawn()` in `runAndroid.js` Its working for people See facebook#23908 (comment) [Android] [Fixed] - projectRoot in launchPackager.bat Pull Request resolved: facebook#24115 Differential Revision: D14597101 Pulled By: cpojer fbshipit-source-id: fb4155b72e35062cfb41fe1b3ecca0e2b4e849ce
kelset
pushed a commit
that referenced
this pull request
Mar 29, 2019
Summary: `launchPackager.bat` starts metro server but does not pass projectRoot to it. So metro server starts in the wrong directory, It is because `startServerInNewWindow` pass `react-native` directory instead of `projectRoot` in the third argument of `spawn()` in `runAndroid.js` Its working for people See #23908 (comment) [Android] [Fixed] - projectRoot in launchPackager.bat Pull Request resolved: #24115 Differential Revision: D14597101 Pulled By: cpojer fbshipit-source-id: fb4155b72e35062cfb41fe1b3ecca0e2b4e849ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
launchPackager.batstarts metro server but does not pass projectRoot to it. So metro server starts in the wrong directory, It is becausestartServerInNewWindowpassreact-nativedirectory instead ofprojectRootin the third argument ofspawn()inrunAndroid.jsIts working for people
See #23908 (comment)
Changelog
[Android] [Fixed] - projectRoot in launchPackager.bat
Test Plan